Commit a9f6273f authored Sep 20, 2016 by Stefan Haberland Committed by Martin Schwidefsky Sep 26, 2016

s390/dasd: fix hanging offline processing

Internal I/O is processed by the _sleep_on_function which might wait for a
device to get operational. During offline processing this will never happen
and therefore the refcount of the device will not drop to zero and the
offline processing blocks as well.

Fix by letting requests fail in the _sleep_on function during offline
processing. No further handling of the requests is necessary since this is
internal I/O and the device is thrown away afterwards.

Reviewed-by: Peter Oberparleiter <oberpar@linux.vnet.ibm.com>
Signed-off-by: Stefan Haberland <sth@linux.vnet.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>

parent 13954fd6

drivers/s390/block/dasd.c

+9 −0

Original line number	Diff line number	Diff line
		@@ -2277,6 +2277,15 @@ static int _dasd_sleep_on(struct dasd_ccw_req *maincqr, int interruptible)
		cqr->intrc = -ENOLINK;
		continue;
		}
		/*
		* Don't try to start requests if device is in
		* offline processing, it might wait forever
		*/
		if (test_bit(DASD_FLAG_OFFLINE, &device->flags)) {
		cqr->status = DASD_CQR_FAILED;
		cqr->intrc = -ENODEV;
		continue;
		}
		/*
		* Don't try to start requests if device is stopped
		* except path verification requests