Commit a9e840a2 authored Apr 19, 2017 by Eric Dumazet Committed by David S. Miller Apr 21, 2017

cx82310_eth: use skb_cow_head() to deal with cloned skbs



We need to ensure there is enough headroom to push extra header,
but we also need to check if we are allowed to change headers.

skb_cow_head() is the proper helper to deal with this.

Fixes: cc28a20e ("introduce cx82310_eth: Conexant CX82310-based ADSL router USB ethernet driver")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: James Hughes <james.hughes@raspberrypi.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent b7c6d267

drivers/net/usb/cx82310_eth.c

+2 −5

Original line number	Diff line number	Diff line
		@@ -293,11 +293,8 @@ static struct sk_buff cx82310_tx_fixup(struct usbnet dev, struct sk_buff *skb,
		{
		int len = skb->len;

		if (skb_headroom(skb) < 2) {
		struct sk_buff *skb2 = skb_copy_expand(skb, 2, 0, flags);
		if (skb_cow_head(skb, 2)) {
		dev_kfree_skb_any(skb);
		skb = skb2;
		if (!skb)
		return NULL;
		}
		skb_push(skb, 2);