Commit a9bb18f3 authored Feb 10, 2010 by Heiko Carstens Committed by Ingo Molnar Feb 14, 2010

tracing/kprobes: Fix probe parsing



Trying to add a probe like:

  echo p:myprobe 0x10000 > /sys/kernel/debug/tracing/kprobe_events

will fail since the wrong pointer is passed to strict_strtoul
when trying to convert the address to an unsigned long.

Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Acked-by: Masami Hiramatsu <mhiramat@redhat.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
LKML-Reference: <20100210162346.GA6933@osiris.boeblingen.de.ibm.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>

parent 4f48f8b7

kernel/trace/trace_kprobe.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -689,7 +689,7 @@ static int create_trace_probe(int argc, char **argv)
		return -EINVAL;
		}
		/* an address specified */
		ret = strict_strtoul(&argv[0][2], 0, (unsigned long *)&addr);
		ret = strict_strtoul(&argv[1][0], 0, (unsigned long *)&addr);
		if (ret) {
		pr_info("Failed to parse address.\n");
		return ret;