Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a98d4f64 authored by Wei Yongjun's avatar Wei Yongjun Committed by Rafael J. Wysocki
Browse files

ACPI / APEI: fix error return code in ghes_probe() 



Fix to return a negative error code in the acpi_gsi_to_irq() and
request_irq() error handling case instead of 0, as done elsewhere
in this function.

Signed-off-by: default avatarWei Yongjun <yongjun_wei@trendmicro.com.cn>
Reviewed-by: default avatarHuang Ying <ying.huang@intel.com>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent 780a6ec6

drivers/acpi/apei/ghes.c

+4 −3
Original line number Diff line number Diff line
@@ -917,13 +917,14 @@ static int ghes_probe(struct platform_device *ghes_dev) 
		break;

	case ACPI_HEST_NOTIFY_EXTERNAL:

		/* External interrupt vector is GSI */

		if (acpi_gsi_to_irq(generic->notify.vector, &ghes->irq)) {

		rc = acpi_gsi_to_irq(generic->notify.vector, &ghes->irq);

		if (rc) {

			pr_err(GHES_PFX "Failed to map GSI to IRQ for generic hardware error source: %d\n",

			       generic->header.source_id);

			goto err_edac_unreg;

		}

		if (request_irq(ghes->irq, ghes_irq_func,

				0, "GHES IRQ", ghes)) {

		rc = request_irq(ghes->irq, ghes_irq_func, 0, "GHES IRQ", ghes);

		if (rc) {

			pr_err(GHES_PFX "Failed to register IRQ for generic hardware error source: %d\n",

			       generic->header.source_id);

			goto err_edac_unreg;