Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a9844881 authored by Jiri Pirko's avatar Jiri Pirko Committed by David S. Miller
Browse files

devlink: remove implicit type set in port register 



As we rely on caller zeroing or correctly set the struct before the call,
this implicit type set is either no-op (DEVLINK_PORT_TYPE_NOTSET is 0)
or it rewrites wanted value. So remove this.

Signed-off-by: default avatarJiri Pirko <jiri@mellanox.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 24d390b2

net/core/devlink.c

+0 −1
Original line number Original line Diff line number Diff line
@@ -630,7 +630,6 @@ int devlink_port_register(struct devlink *devlink, 
	}

	}

	devlink_port->devlink = devlink;

	devlink_port->devlink = devlink;

	devlink_port->index = port_index;

	devlink_port->index = port_index;

	devlink_port->type = DEVLINK_PORT_TYPE_NOTSET;

	devlink_port->registered = true;

	devlink_port->registered = true;

	list_add_tail(&devlink_port->list, &devlink->port_list);

	list_add_tail(&devlink_port->list, &devlink->port_list);

	mutex_unlock(&devlink_port_mutex);

	mutex_unlock(&devlink_port_mutex);