Commit a96afc6b authored May 15, 2013 by Fabio Baltieri Committed by Felipe Balbi May 28, 2013

usb: phy: ab8500-usb: fix phy tuning value select logic



The driver supports both ab8500 and ab8505, but the actual phy tuning
values logic sets ab8500 values:

if (!is_ab8500_2p0_or_earlier(ab->ab8500))

which is supposed to set values for ab8500, but incorrectly results true
for ab8505 too.

Fix this by adding an additional is_ab8500(ab->ab8500) check.

Acked-by: Linus Walleij <linus.walleij@linaro.org>
Acked-by: Maxime Coquelin <maxime.coquelin@st.com>
Signed-off-by: Fabio Baltieri <fabio.baltieri@linaro.org>
Signed-off-by: Felipe Balbi <balbi@ti.com>

parent fb21f37a

drivers/usb/phy/phy-ab8500-usb.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -835,8 +835,8 @@ static int ab8500_usb_probe(struct platform_device *pdev)
		return err;
		}

		/* Phy tuning values for AB8500 */
		if (!is_ab8500_2p0_or_earlier(ab->ab8500)) {
		/* Phy tuning values for AB8500 > v2.0 */
		if (is_ab8500(ab->ab8500) && !is_ab8500_2p0_or_earlier(ab->ab8500)) {
		/* Enable the PBT/Bank 0x12 access */
		err = abx500_set_register_interruptible(ab->dev,
		AB8500_DEVELOPMENT, AB8500_BANK12_ACCESS, 0x01);