Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a95d6511 authored by Nicholas Bellinger's avatar Nicholas Bellinger
Browse files

target: Use complete_all for se_cmd->t_transport_stop_comp 



This patch fixes a bug where multiple waiters on ->t_transport_stop_comp
occurs due to a concurrent ABORT_TASK and session reset both invoking
transport_wait_for_tasks(), while waiting for the associated se_cmd
descriptor backend processing to complete.

For this case, complete_all() should be invoked in order to wake up
both waiters in core_tmr_abort_task() + transport_generic_free_cmd()
process contexts.

Cc: Thomas Glanzmann <thomas@glanzmann.de>
Cc: Charalampos Pournaris <charpour@gmail.com>
Cc: stable@vger.kernel.org # 3.10+
Signed-off-by: default avatarNicholas Bellinger <nab@linux-iscsi.org>
parent f15e9cd9

drivers/target/target_core_transport.c

+3 −3
Original line number Diff line number Diff line
@@ -562,7 +562,7 @@ static int transport_cmd_check_stop(struct se_cmd *cmd, bool remove_from_lists, 


		spin_unlock_irqrestore(&cmd->t_state_lock, flags);



		complete(&cmd->t_transport_stop_comp);

		complete_all(&cmd->t_transport_stop_comp);

		return 1;

	}
@@ -687,7 +687,7 @@ void target_complete_cmd(struct se_cmd *cmd, u8 scsi_status) 
	if (cmd->transport_state & CMD_T_ABORTED &&

	    cmd->transport_state & CMD_T_STOP) {

		spin_unlock_irqrestore(&cmd->t_state_lock, flags);

		complete(&cmd->t_transport_stop_comp);

		complete_all(&cmd->t_transport_stop_comp);

		return;

	} else if (!success) {

		INIT_WORK(&cmd->work, target_complete_failure_work);
@@ -1761,7 +1761,7 @@ void target_execute_cmd(struct se_cmd *cmd) 
			cmd->se_tfo->get_task_tag(cmd));



		spin_unlock_irq(&cmd->t_state_lock);

		complete(&cmd->t_transport_stop_comp);

		complete_all(&cmd->t_transport_stop_comp);

		return;

	}