Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a905b82e authored by Pablo Neira Ayuso's avatar Pablo Neira Ayuso Committed by Greg Kroah-Hartman
Browse files

netfilter: nft_compat: use-after-free when deleting targets 



commit 753c111f655e38bbd52fc01321266633f022ebe2 upstream.

Fetch pointer to module before target object is released.

Fixes: 29e3880109e3 ("netfilter: nf_tables: fix use-after-free when deleting compat expressions")
Fixes: 0ca743a5 ("netfilter: nf_tables: add compatibility layer for x_tables")
Signed-off-by: default avatarPablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 1500d94e

net/netfilter/nft_compat.c

+2 −1
Original line number Diff line number Diff line
@@ -282,6 +282,7 @@ nft_target_destroy(const struct nft_ctx *ctx, const struct nft_expr *expr) 
{

	struct xt_target *target = expr->ops->data;

	void *info = nft_expr_priv(expr);

	struct module *me = target->me;

	struct xt_tgdtor_param par;



	par.net = ctx->net;
@@ -292,7 +293,7 @@ nft_target_destroy(const struct nft_ctx *ctx, const struct nft_expr *expr) 
		par.target->destroy(&par);



	if (nft_xt_put(container_of(expr->ops, struct nft_xt, ops)))

		module_put(target->me);

		module_put(me);

}



static int nft_target_dump(struct sk_buff *skb, const struct nft_expr *expr)