Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a8f688ec authored by Chuck Lever's avatar Chuck Lever Committed by Anna Schumaker
Browse files

xprtrdma: Return -ENOBUFS when no pages are available 



The use of -EAGAIN in rpcrdma_convert_iovs() is a latent bug: the
transport never calls xprt_write_space() when more pages become
available. -ENOBUFS will trigger the correct "delay briefly and call
again" logic.

Fixes: 7a89f9c6 ("xprtrdma: Honor ->send_request API contract")
Signed-off-by: default avatarChuck Lever <chuck.lever@oracle.com>
Cc: stable@vger.kernel.org # 4.8+
Signed-off-by: default avatarAnna Schumaker <Anna.Schumaker@Netapp.com>
parent efd81e90

net/sunrpc/xprtrdma/rpc_rdma.c

+1 −1
Original line number Diff line number Diff line
@@ -231,7 +231,7 @@ rpcrdma_convert_iovs(struct rpcrdma_xprt *r_xprt, struct xdr_buf *xdrbuf, 
			 */

			*ppages = alloc_page(GFP_ATOMIC);

			if (!*ppages)

				return -EAGAIN;

				return -ENOBUFS;

		}

		seg->mr_page = *ppages;

		seg->mr_offset = (char *)page_base;