Commit a8f40f46 authored Jan 10, 2013 by H Hartley Sweeten Committed by Greg Kroah-Hartman Jan 17, 2013

staging: comedi: comedi_buf: remove unreachable dev_warn in comedi_buf_munge()



Due to the 'while(count < num_bytes)' the computed 'block_size' will
always be a value greater than 0.

Remove the unreachable dev_warn and the (block_size < 0) test.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbobbi@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 305a6f38

drivers/staging/comedi/comedi_buf.c

+0 −7

Original line number	Diff line number	Diff line
		@@ -215,13 +215,6 @@ static unsigned int comedi_buf_munge(struct comedi_async *async,
		int block_size = num_bytes - count;
		unsigned int buf_end;

		if (block_size < 0) {
		dev_warn(s->device->class_dev,
		"%s: %s: bug! block_size is negative\n",
		__FILE__, __func__);
		break;
		}

		buf_end = async->prealloc_bufsz - async->munge_ptr;
		if (block_size > buf_end)
		block_size = buf_end;