Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a8d78984 authored by Aleksandr Mishin's avatar Aleksandr Mishin Committed by Greg Kroah-Hartman
Browse files

gpio: davinci: Validate the obtained number of IRQs 



[ Upstream commit 7aa9b96e9a73e4ec1771492d0527bd5fc5ef9164 ]

Value of pdata->gpio_unbanked is taken from Device Tree. In case of broken
DT due to any error this value can be any. Without this value validation
there can be out of chips->irqs array boundaries access in
davinci_gpio_probe().

Validate the obtained nirq value so that it won't exceed the maximum
number of IRQs per bank.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: eb3744a2 ("gpio: davinci: Do not assume continuous IRQ numbering")
Signed-off-by: default avatarAleksandr Mishin <amishin@t-argos.ru>
Link: https://lore.kernel.org/r/20240618144344.16943-1-amishin@t-argos.ru


Signed-off-by: default avatarBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 277ea9f9

drivers/gpio/gpio-davinci.c

+5 −0
Original line number Diff line number Diff line
@@ -207,6 +207,11 @@ static int davinci_gpio_probe(struct platform_device *pdev) 
	else

		nirq = DIV_ROUND_UP(ngpio, 16);



	if (nirq > MAX_INT_PER_BANK) {

		dev_err(dev, "Too many IRQs!\n");

		return -EINVAL;

	}



	nbank = DIV_ROUND_UP(ngpio, 32);

	chips = devm_kcalloc(dev,

			     nbank, sizeof(struct davinci_gpio_controller),