Commit a8461c0f authored Jul 22, 2010 by Stefan Richter

tools/firewire: nosy-dump: work around segfault in decode_fcp



If I run "nosy-dump --view=transaction" with my camcorder on battery
instead of mains, it segfaults very quickly because of !t->request.
Perhaps this is because of increased likelyhood of incomplete
transactions (ack_busy when host writes to camcorder's FCP_Request)
and a bug deeper in nosy-dump's transaction housekeeping.  This is a
quick workaround to get me going.

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>

parent 1bcc69fb

tools/firewire/nosy-dump.c

+5 −0

Original line number	Diff line number	Diff line
		@@ -230,6 +230,11 @@ handle_transaction(struct link_transaction *t)
		struct subaction *sa;
		int i;

		if (!t->request) {
		printf("BUG in handle_transaction\n");
		return;
		}

		for (i = 0; i < array_length(protocol_decoders); i++)
		if (protocol_decoders[i].decode(t))
		break;