Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a8272ce0 authored by David Chinner's avatar David Chinner Committed by Lachlan McIlroy
Browse files

[XFS] Fix up sparse warnings. 



These are mostly locking annotations, marking things static, casts where
needed and declaring stuff in header files.

SGI-PV: 971186
SGI-Modid: xfs-linux-melb:xfs-kern:30002a

Signed-off-by: default avatarDavid Chinner <dgc@sgi.com>
Signed-off-by: default avatarChristoph Hellwig <hch@infradead.org>
Signed-off-by: default avatarLachlan McIlroy <lachlan@sgi.com>
parent a69b176d

fs/xfs/linux-2.6/xfs_globals.c

+2 −1
Original line number Diff line number Diff line
@@ -47,5 +47,6 @@ xfs_param_t xfs_params = { 
/*

 * Global system credential structure.

 */

cred_t sys_cred_val, *sys_cred = &sys_cred_val;

static cred_t sys_cred_val;

cred_t *sys_cred = &sys_cred_val;

fs/xfs/linux-2.6/xfs_ioctl.c

+1 −1
Original line number Diff line number Diff line
@@ -512,7 +512,7 @@ xfs_attrmulti_attr_get( 
	if (!kbuf)

		return ENOMEM;



	error = xfs_attr_get(XFS_I(inode), name, kbuf, len, flags, NULL);

	error = xfs_attr_get(XFS_I(inode), name, kbuf, (int *)len, flags, NULL);

	if (error)

		goto out_kfree;

fs/xfs/linux-2.6/xfs_ioctl32.c

+1 −0
Original line number Diff line number Diff line
@@ -44,6 +44,7 @@ 
#include "xfs_error.h"

#include "xfs_dfrag.h"

#include "xfs_vnodeops.h"

#include "xfs_ioctl32.h"



#define  _NATIVE_IOC(cmd, type) \

	  _IOC(_IOC_DIR(cmd), _IOC_TYPE(cmd), _IOC_NR(cmd), sizeof(type))

fs/xfs/xfs_attr.c

+1 −1
Original line number Diff line number Diff line
@@ -929,7 +929,7 @@ xfs_attr_shortform_addname(xfs_da_args_t *args) 
 * This leaf block cannot have a "remote" value, we only call this routine

 * if bmap_one_block() says there is only one block (ie: no remote blks).

 */

int

STATIC int

xfs_attr_leaf_addname(xfs_da_args_t *args)

{

	xfs_inode_t *dp;

fs/xfs/xfs_bmap.c

+3 −3
Original line number Diff line number Diff line
@@ -6393,7 +6393,7 @@ xfs_bmap_count_blocks( 
 * Recursively walks each level of a btree

 * to count total fsblocks is use.

 */

int                                     /* error */

STATIC int                                     /* error */

xfs_bmap_count_tree(

	xfs_mount_t     *mp,            /* file system mount point */

	xfs_trans_t     *tp,            /* transaction pointer */
@@ -6469,7 +6469,7 @@ xfs_bmap_count_tree( 
/*

 * Count leaf blocks given a range of extent records.

 */

int

STATIC int

xfs_bmap_count_leaves(

	xfs_ifork_t		*ifp,

	xfs_extnum_t		idx,
@@ -6489,7 +6489,7 @@ xfs_bmap_count_leaves( 
 * Count leaf blocks given a range of extent records originally

 * in btree format.

 */

int

STATIC int

xfs_bmap_disk_count_leaves(

	xfs_extnum_t		idx,

	xfs_bmbt_block_t	*block,