Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a809eff1 authored by Fabian Frederick's avatar Fabian Frederick Committed by Marcel Holtmann
Browse files

Bluetooth: hidp: replace kzalloc/copy_from_user by memdup_user 



use memdup_user for rd_data import.

Signed-off-by: default avatarFabian Frederick <fabf@skynet.be>
Signed-off-by: default avatarMarcel Holtmann <marcel@holtmann.org>
parent 2773b024

net/bluetooth/hidp/core.c

+3 −7
Original line number Diff line number Diff line
@@ -736,14 +736,10 @@ static int hidp_setup_hid(struct hidp_session *session, 
	struct hid_device *hid;

	int err;



	session->rd_data = kzalloc(req->rd_size, GFP_KERNEL);

	if (!session->rd_data)

		return -ENOMEM;

	session->rd_data = memdup_user(req->rd_data, req->rd_size);

	if (IS_ERR(session->rd_data))

		return PTR_ERR(session->rd_data);



	if (copy_from_user(session->rd_data, req->rd_data, req->rd_size)) {

		err = -EFAULT;

		goto fault;

	}

	session->rd_size = req->rd_size;



	hid = hid_allocate_device();