Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a7a19d7a authored by Markus Elfring's avatar Markus Elfring Committed by Greg Kroah-Hartman
Browse files

USB-EHCI: Delete unnecessary checks before the function call "dma_pool_destroy" 



The dma_pool_destroy() function tests whether its argument is NULL
and then returns immediately. Thus the test around the calls is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: default avatarMarkus Elfring <elfring@users.sourceforge.net>
Acked-by: default avatarAlan Stern <stern@rowland.harvard.edu>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 84c1eeb0

drivers/usb/host/ehci-mem.c

+5 −13
Original line number Diff line number Diff line
@@ -128,20 +128,12 @@ static void ehci_mem_cleanup (struct ehci_hcd *ehci) 
	ehci->dummy = NULL;



	/* DMA consistent memory and pools */

	if (ehci->qtd_pool)

	dma_pool_destroy(ehci->qtd_pool);

	ehci->qtd_pool = NULL;



	if (ehci->qh_pool) {

	dma_pool_destroy(ehci->qh_pool);

	ehci->qh_pool = NULL;

	}



	if (ehci->itd_pool)

	dma_pool_destroy(ehci->itd_pool);

	ehci->itd_pool = NULL;



	if (ehci->sitd_pool)

	dma_pool_destroy(ehci->sitd_pool);

	ehci->sitd_pool = NULL;