Commit a72040a9 authored Jan 24, 2019 by Boris Brezillon Committed by Greg Kroah-Hartman Feb 15, 2019

mtd: spinand: Fix the error/cleanup path in spinand_init()



commit c3c7dbf4887ab3ed9d611cd1f6e16937f8700743 upstream.

The manufacturer specific initialization has already been done when
block unlocking takes place, and if anything goes wrong during this
procedure we should call spinand_manufacturer_cleanup().

Fixes: 7529df46 ("mtd: nand: Add core infrastructure to support SPI NANDs")
Cc: <stable@vger.kernel.org>
Signed-off-by: Boris Brezillon <bbrezillon@kernel.org>
Acked-by: Miquel Raynal <miquel.raynal@bootlin.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent b3ce7757

drivers/mtd/nand/spi/core.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -1014,11 +1014,11 @@ static int spinand_init(struct spinand_device *spinand)
		for (i = 0; i < nand->memorg.ntargets; i++) {
		ret = spinand_select_target(spinand, i);
		if (ret)
		goto err_free_bufs;
		goto err_manuf_cleanup;

		ret = spinand_lock_block(spinand, BL_ALL_UNLOCKED);
		if (ret)
		goto err_free_bufs;
		goto err_manuf_cleanup;
		}

		ret = nanddev_init(nand, &spinand_ops, THIS_MODULE);