Commit a69261e4 authored Feb 07, 2017 by Dan Carpenter Committed by Rafael J. Wysocki Feb 09, 2017

cpufreq: s3c2416: double free on driver init error path



The "goto err_armclk;" error path already does a clk_put(s3c_freq->hclk);
so this is a double free.

Fixes: 34ee5507 ([CPUFREQ] Add S3C2416/S3C2450 cpufreq driver)
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

parent 2a96c9ec

drivers/cpufreq/s3c2416-cpufreq.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -400,7 +400,6 @@ static int s3c2416_cpufreq_driver_init(struct cpufreq_policy *policy)
		rate = clk_get_rate(s3c_freq->hclk);
		if (rate < 133 * 1000 * 1000) {
		pr_err("cpufreq: HCLK not at 133MHz\n");
		clk_put(s3c_freq->hclk);
		ret = -EINVAL;
		goto err_armclk;
		}