Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a672eb5e authored by Masahiro Yamada's avatar Masahiro Yamada Committed by Linus Walleij
Browse files

pinctrl: pinconf: separate config parameters with commas for debugfs 



To improve debugfs readability, use commas instead of whitespaces
for separating configuration parameters.

For example, the "pinconf-pins" dump on my board will change as follows:

Without this commit:

 # head -5 pinconf-pins
 Pin config settings per pin
 Format: pin (name): configs
 pin 0 (ED0): input bias pull down output drive strength (8 mA) input enabled
 pin 1 (ED1): input bias pull down output drive strength (8 mA) input enabled
 pin 2 (ED2): input bias pull down output drive strength (8 mA) input enabled

With this commit:

 # head -5 pinconf-pins
 Pin config settings per pin
 Format: pin (name): configs
 pin 0 (ED0): input bias pull down, output drive strength (8 mA), input enabled
 pin 1 (ED1): input bias pull down, output drive strength (8 mA), input enabled
 pin 2 (ED2): input bias pull down, output drive strength (8 mA), input enabled

Signed-off-by: default avatarMasahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent cd8f61f1

drivers/pinctrl/pinconf-generic.c

+9 −5
Original line number Diff line number Diff line
@@ -53,7 +53,7 @@ static void pinconf_generic_dump_one(struct pinctrl_dev *pctldev, 
				     struct seq_file *s, const char *gname,

				     unsigned pin,

				     const struct pin_config_item *items,

				     int nitems)

				     int nitems, int *print_sep)

{

	int i;
@@ -75,8 +75,10 @@ static void pinconf_generic_dump_one(struct pinctrl_dev *pctldev, 
			seq_printf(s, "ERROR READING CONFIG SETTING %d ", i);

			continue;

		}

		/* Space between multiple configs */

		seq_puts(s, " ");

		/* comma between multiple configs */

		if (*print_sep)

			seq_puts(s, ", ");

		*print_sep = 1;

		seq_puts(s, items[i].display);

		/* Print unit if available */

		if (items[i].has_arg) {
@@ -105,19 +107,21 @@ void pinconf_generic_dump_pins(struct pinctrl_dev *pctldev, struct seq_file *s, 
			       const char *gname, unsigned pin)

{

	const struct pinconf_ops *ops = pctldev->desc->confops;

	int print_sep = 0;



	if (!ops->is_generic)

		return;



	/* generic parameters */

	pinconf_generic_dump_one(pctldev, s, gname, pin, conf_items,

				 ARRAY_SIZE(conf_items));

				 ARRAY_SIZE(conf_items), &print_sep);

	/* driver-specific parameters */

	if (pctldev->desc->num_custom_params &&

	    pctldev->desc->custom_conf_items)

		pinconf_generic_dump_one(pctldev, s, gname, pin,

					 pctldev->desc->custom_conf_items,

					 pctldev->desc->num_custom_params);

					 pctldev->desc->num_custom_params,

					 &print_sep);

}



void pinconf_generic_dump_config(struct pinctrl_dev *pctldev,

drivers/pinctrl/pinconf.c

+2 −2

File changed.

Contains only whitespace changes.