Commit a6411f3c authored Jun 13, 2024 by Florian Westphal Committed by Greg Kroah-Hartman Jun 16, 2024

netfilter: nf_tables: set dormant flag on hook register failure



[ Upstream commit bccebf64701735533c8db37773eeacc6566cc8ec ]

We need to set the dormant flag again if we fail to register
the hooks.

During memory pressure hook registration can fail and we end up
with a table marked as active but no registered hooks.

On table/base chain deletion, nf_tables will attempt to unregister
the hook again which yields a warn splat from the nftables core.

Reported-and-tested-by:  <syzbot+de4025c006ec68ac56fc@syzkaller.appspotmail.com>
Fixes: 179d9ba5559a ("netfilter: nf_tables: fix table flag updates")
Signed-off-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent c60d2529

net/netfilter/nf_tables_api.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -925,6 +925,7 @@ static int nf_tables_updtable(struct nft_ctx *ctx)
		return 0;

		err_register_hooks:
		ctx->table->flags \|= NFT_TABLE_F_DORMANT;
		nft_trans_destroy(trans);
		return ret;
		}