Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a5ece7d2 authored by Linus Walleij's avatar Linus Walleij Committed by Chris Ball
Browse files

mmc: sh_mmcif: use dmaengine helpers, drop submit check 



Use the new dmaengine helper functions, and drop the error check
on the returned cookier from the dmaengine - we recently
established that this is really not allowed to fail.

Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Signed-off-by: default avatarChris Ball <cjb@laptop.org>
parent f38f94c6

drivers/mmc/host/sh_mmcif.c

+6 −16
Original line number Diff line number Diff line
@@ -224,14 +224,9 @@ static void sh_mmcif_start_dma_rx(struct sh_mmcif_host *host) 
	if (desc) {

		desc->callback = mmcif_dma_complete;

		desc->callback_param = host;

		cookie = desc->tx_submit(desc);

		if (cookie < 0) {

			desc = NULL;

			ret = cookie;

		} else {

		cookie = dmaengine_submit(desc);

		sh_mmcif_bitset(host, MMCIF_CE_BUF_ACC, BUF_ACC_DMAREN);

			chan->device->device_issue_pending(chan);

		}

		dma_async_issue_pending(chan);

	}

	dev_dbg(&host->pd->dev, "%s(): mapped %d -> %d, cookie %d\n",

		__func__, host->data->sg_len, ret, cookie);
@@ -277,14 +272,9 @@ static void sh_mmcif_start_dma_tx(struct sh_mmcif_host *host) 
	if (desc) {

		desc->callback = mmcif_dma_complete;

		desc->callback_param = host;

		cookie = desc->tx_submit(desc);

		if (cookie < 0) {

			desc = NULL;

			ret = cookie;

		} else {

		cookie = dmaengine_submit(desc);

		sh_mmcif_bitset(host, MMCIF_CE_BUF_ACC, BUF_ACC_DMAWEN);

			chan->device->device_issue_pending(chan);

		}

		dma_async_issue_pending(chan);

	}

	dev_dbg(&host->pd->dev, "%s(): mapped %d -> %d, cookie %d\n",

		__func__, host->data->sg_len, ret, cookie);