Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a5c9c71f authored by H Hartley Sweeten's avatar H Hartley Sweeten Committed by Greg Kroah-Hartman
Browse files

staging: comedi: cb_pcidas64: remove unnecessary Step 2b test in (*do_cmdtest) 



This test is unnecessary. The cfc_check_trigger_src() in Step 1 ensures that
the trigger source is one of these values and Step 2 makes sure it's only one
of these values.

Signed-off-by: default avatarH Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: default avatarIan Abbott <abbotti@mev.co.uk>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 0fb21b2c

drivers/staging/comedi/drivers/cb_pcidas64.c

+0 −3
Original line number Diff line number Diff line
@@ -2078,9 +2078,6 @@ static int ai_cmdtest(struct comedi_device *dev, struct comedi_subdevice *s, 


	if (cmd->convert_src == TRIG_EXT && cmd->scan_begin_src == TRIG_TIMER)

		err |= -EINVAL;

	if (cmd->stop_src != TRIG_COUNT &&

	    cmd->stop_src != TRIG_NONE && cmd->stop_src != TRIG_EXT)

		err |= -EINVAL;



	if (err)

		return 2;