Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a55cc70a authored by Heiner Kallweit's avatar Heiner Kallweit Committed by Wolfram Sang
Browse files

i2c: meson: remove member irq from struct meson_i2c 



Member irq can be replaced with a local variable in probe
because it's nowhere else accessed.

Signed-off-by: default avatarHeiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: default avatarJerome Brunet <jbrunet@baylibre.com>
Signed-off-by: default avatarWolfram Sang <wsa@the-dreams.de>
parent 8edf52a1

drivers/i2c/busses/i2c-meson.c

+5 −7
Original line number Diff line number Diff line
@@ -82,7 +82,6 @@ struct meson_i2c { 
	struct device		*dev;

	void __iomem		*regs;

	struct clk		*clk;

	int			irq;



	struct i2c_msg		*msg;

	int			state;
@@ -391,7 +390,7 @@ static int meson_i2c_probe(struct platform_device *pdev) 
	struct device_node *np = pdev->dev.of_node;

	struct meson_i2c *i2c;

	struct resource *mem;

	int ret = 0;

	int irq, ret = 0;



	i2c = devm_kzalloc(&pdev->dev, sizeof(struct meson_i2c), GFP_KERNEL);

	if (!i2c)
@@ -418,14 +417,13 @@ static int meson_i2c_probe(struct platform_device *pdev) 
	if (IS_ERR(i2c->regs))

		return PTR_ERR(i2c->regs);



	i2c->irq = platform_get_irq(pdev, 0);

	if (i2c->irq < 0) {

	irq = platform_get_irq(pdev, 0);

	if (irq < 0) {

		dev_err(&pdev->dev, "can't find IRQ\n");

		return i2c->irq;

		return irq;

	}



	ret = devm_request_irq(&pdev->dev, i2c->irq, meson_i2c_irq,

			       0, dev_name(&pdev->dev), i2c);

	ret = devm_request_irq(&pdev->dev, irq, meson_i2c_irq, 0, NULL, i2c);

	if (ret < 0) {

		dev_err(&pdev->dev, "can't request IRQ\n");

		return ret;