Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a5598bd9 authored by Mathias Krause's avatar Mathias Krause Committed by David S. Miller
Browse files

iucv: Fix missing msg_namelen update in iucv_sock_recvmsg()



The current code does not fill the msg_name member in case it is set.
It also does not set the msg_namelen member to 0 and therefore makes
net/socket.c leak the local, uninitialized sockaddr_storage variable
to userland -- 128 bytes of kernel stack memory.

Fix that by simply setting msg_namelen to 0 as obviously nobody cared
about iucv_sock_recvmsg() not filling the msg_name in case it was set.

Cc: Ursula Braun <ursula.braun@de.ibm.com>
Signed-off-by: default avatarMathias Krause <minipli@googlemail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 5ae94c0d
Loading
Loading
Loading
Loading
+2 −0
Original line number Diff line number Diff line
@@ -1328,6 +1328,8 @@ static int iucv_sock_recvmsg(struct kiocb *iocb, struct socket *sock,
	struct sk_buff *skb, *rskb, *cskb;
	int err = 0;

	msg->msg_namelen = 0;

	if ((sk->sk_state == IUCV_DISCONN) &&
	    skb_queue_empty(&iucv->backlog_skb_q) &&
	    skb_queue_empty(&sk->sk_receive_queue) &&