Commit a4fd6f3d authored Dec 14, 2022 by Biju Das Committed by Greg Kroah-Hartman Jan 18, 2023

ravb: Fix "failed to switch device to config mode" message during unbind



[ Upstream commit c72a7e42592b2e18d862cf120876070947000d7a ]

This patch fixes the error "ravb 11c20000.ethernet eth0: failed to switch
device to config mode" during unbind.

We are doing register access after pm_runtime_put_sync().

We usually do cleanup in reverse order of init. Currently in
remove(), the "pm_runtime_put_sync" is not in reverse order.

Probe
	reset_control_deassert(rstc);
	pm_runtime_enable(&pdev->dev);
	pm_runtime_get_sync(&pdev->dev);

remove
	pm_runtime_put_sync(&pdev->dev);
	unregister_netdev(ndev);
	..
	ravb_mdio_release(priv);
	pm_runtime_disable(&pdev->dev);

Consider the call to unregister_netdev()
unregister_netdev->unregister_netdevice_queue->rollback_registered_many
that calls the below functions which access the registers after
pm_runtime_put_sync()
 1) ravb_get_stats
 2) ravb_close

Fixes: c156633f ("Renesas Ethernet AVB driver proper")
Cc: stable@vger.kernel.org
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
Link: https://lore.kernel.org/r/20221214105118.2495313-1-biju.das.jz@bp.renesas.com


Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 9c219794

drivers/net/ethernet/renesas/ravb_main.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2199,11 +2199,11 @@ static int ravb_remove(struct platform_device *pdev)
		priv->desc_bat_dma);
		/* Set reset mode */
		ravb_write(ndev, CCC_OPC_RESET, CCC);
		pm_runtime_put_sync(&pdev->dev);
		unregister_netdev(ndev);
		netif_napi_del(&priv->napi[RAVB_NC]);
		netif_napi_del(&priv->napi[RAVB_BE]);
		ravb_mdio_release(priv);
		pm_runtime_put_sync(&pdev->dev);
		pm_runtime_disable(&pdev->dev);
		free_netdev(ndev);
		platform_set_drvdata(pdev, NULL);