Commit a4de018d authored Feb 15, 2016 by Alan Committed by Peter Chen Feb 19, 2016

usb: chipidea: error on overflow for port_test_write



The write value is 8bit, but currently writing a larger number
(eg a doubled digit) is not errored but instead gets cast and
sets off an action probably undesired.

Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Peter Chen <peter.chen@nxp.com>
(Change the style of commit log to fix checkpatch.pl warning)

parent 18558cae

drivers/usb/chipidea/debug.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -100,6 +100,9 @@ static ssize_t ci_port_test_write(struct file file, const char __user ubuf,
		if (sscanf(buf, "%u", &mode) != 1)
		return -EINVAL;

		if (mode > 255)
		return -EBADRQC;

		pm_runtime_get_sync(ci->dev);
		spin_lock_irqsave(&ci->lock, flags);
		ret = hw_port_test_set(ci, mode);