Commit a4cc93ec authored Jan 06, 2021 by Mike Snitzer Committed by Greg Kroah-Hartman Jan 19, 2021

dm: eliminate potential source of excessive kernel log noise



commit 0378c625afe80eb3f212adae42cc33c9f6f31abf upstream.

There wasn't ever a real need to log an error in the kernel log for
ioctls issued with insufficient permissions. Simply return an error
and if an admin/user is sufficiently motivated they can enable DM's
dynamic debugging to see an explanation for why the ioctls were
disallowed.

Reported-by: Nir Soffer <nsoffer@redhat.com>
Fixes: e980f623 ("dm: don't allow ioctls to targets that don't map to whole devices")
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent f6ced16c

drivers/md/dm.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -515,7 +515,7 @@ static int dm_blk_ioctl(struct block_device *bdev, fmode_t mode,
		* subset of the parent bdev; require extra privileges.
		*/
		if (!capable(CAP_SYS_RAWIO)) {
		DMWARN_LIMIT(
		DMDEBUG_LIMIT(
		"%s: sending ioctl %x to DM device without required privilege.",
		current->comm, cmd);
		r = -ENOIOCTLCMD;