Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a44c72f3 authored Jun 25, 2013 by Bart Van Assche Committed by James Bottomley Jul 08, 2013

[SCSI] qla2xxx: Clean up qla84xx_mgmt_cmd()



Remove dead code, simplify a pointer computation and move the
ql84_mgmt assignment to just before its first use.

Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Saurav Kashyap <saurav.kashyap@qlogic.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>

parent 090fc2e2

drivers/scsi/qla2xxx/qla_bsg.c

+1 −9

Original line number	Diff line number	Diff line
		@@ -1084,14 +1084,6 @@ qla84xx_mgmt_cmd(struct fc_bsg_job *bsg_job)
		return -EINVAL;
		}

		ql84_mgmt = (struct qla_bsg_a84_mgmt )((char )bsg_job->request +
		sizeof(struct fc_bsg_request));
		if (!ql84_mgmt) {
		ql_log(ql_log_warn, vha, 0x703b,
		"MGMT header not provided, exiting.\n");
		return -EINVAL;
		}

		mn = dma_pool_alloc(ha->s_dma_pool, GFP_KERNEL, &mn_dma);
		if (!mn) {
		ql_log(ql_log_warn, vha, 0x703c,
		@@ -1102,7 +1094,7 @@ qla84xx_mgmt_cmd(struct fc_bsg_job *bsg_job)
		memset(mn, 0, sizeof(struct access_chip_84xx));
		mn->entry_type = ACCESS_CHIP_IOCB_TYPE;
		mn->entry_count = 1;

		ql84_mgmt = (void *)bsg_job->request + sizeof(struct fc_bsg_request);
		switch (ql84_mgmt->mgmt.cmd) {
		case QLA84_MGMT_READ_MEM:
		case QLA84_MGMT_GET_INFO:

drivers/scsi/qla2xxx/qla_dbg.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -36,7 +36,7 @@
		* \| \| \| 0x70a8,0x70ab, \|
		* \| \| \| 0x70ad-0x70ae, \|
		* \| \| \| 0x70d1-0x70da, \|
		* \| \| \| 0x7047 \|
		* \| \| \| 0x7047,0x703b \|
		* \| Task Management \| 0x803c \| 0x8025-0x8026 \|
		* \| \| \| 0x800b,0x8039 \|
		* \| AER/EEH \| 0x9011 \| \|