Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a30c7c81 authored by Jiasheng Jiang's avatar Jiasheng Jiang Committed by Greg Kroah-Hartman
Browse files

hv_netvsc: Add check for kvmalloc_array 



[ Upstream commit 886e44c9298a6b428ae046e2fa092ca52e822e6a ]

As the potential failure of the kvmalloc_array(),
it should be better to check and restore the 'data'
if fails in order to avoid the dereference of the
NULL pointer.

Fixes: 6ae74671 ("hv_netvsc: Add per-cpu ethtool stats for netvsc")
Signed-off-by: default avatarJiasheng Jiang <jiasheng@iscas.ac.cn>
Link: https://lore.kernel.org/r/20220314020125.2365084-1-jiasheng@iscas.ac.cn


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 3202d538

drivers/net/hyperv/netvsc_drv.c

+3 −0
Original line number Original line Diff line number Diff line
@@ -1454,6 +1454,9 @@ static void netvsc_get_ethtool_stats(struct net_device *dev, 
	pcpu_sum = kvmalloc_array(num_possible_cpus(),

	pcpu_sum = kvmalloc_array(num_possible_cpus(),

				  sizeof(struct netvsc_ethtool_pcpu_stats),

				  sizeof(struct netvsc_ethtool_pcpu_stats),

				  GFP_KERNEL);

				  GFP_KERNEL);

	if (!pcpu_sum)

		return;



	netvsc_get_pcpu_stats(dev, pcpu_sum);

	netvsc_get_pcpu_stats(dev, pcpu_sum);

	for_each_present_cpu(cpu) {

	for_each_present_cpu(cpu) {

		struct netvsc_ethtool_pcpu_stats *this_sum = &pcpu_sum[cpu];

		struct netvsc_ethtool_pcpu_stats *this_sum = &pcpu_sum[cpu];