Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a308f3a8 authored by Arnaldo Carvalho de Melo's avatar Arnaldo Carvalho de Melo
Browse files

perf tui: Make <- exit menus too 



In fact it is now added to the hot key list when newt_form__new is used,
allowing us to remove the explicit assignment in all its users.

The visible change is that <- will exit the menu that pops up when -> is
pressed (and Enter when callchains are not being used).

Suggested-by: default avatarIngo Molnar <mingo@elte.hu>
Cc: Frédéric Weisbecker <fweisbec@gmail.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Tom Zanussi <tzanussi@gmail.com>
LKML-Reference: <new-submission>
Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent 9d192e11

tools/perf/util/newt.c

+1 −2
Original line number Diff line number Diff line
@@ -118,6 +118,7 @@ int browser__show_help(const char *format, va_list ap) 


static void newt_form__set_exit_keys(newtComponent self)

{

	newtFormAddHotKey(self, NEWT_KEY_LEFT);

	newtFormAddHotKey(self, NEWT_KEY_ESCAPE);

	newtFormAddHotKey(self, 'Q');

	newtFormAddHotKey(self, 'q');
@@ -323,7 +324,6 @@ static int ui_browser__run(struct ui_browser *self, const char *title, 
	newtFormAddHotKey(self->form, NEWT_KEY_PGDN);

	newtFormAddHotKey(self->form, NEWT_KEY_HOME);

	newtFormAddHotKey(self->form, NEWT_KEY_END);

	newtFormAddHotKey(self->form, NEWT_KEY_LEFT);



	if (ui_browser__refresh_entries(self) < 0)

		return -1;
@@ -757,7 +757,6 @@ static int hist_browser__populate(struct hist_browser *self, struct hists *hists 
	newtFormAddHotKey(self->form, 'T');

	newtFormAddHotKey(self->form, 't');

	newtFormAddHotKey(self->form, NEWT_KEY_RIGHT);

	newtFormAddHotKey(self->form, NEWT_KEY_LEFT);

	newtFormAddComponents(self->form, self->tree, NULL);

	self->selection = newt__symbol_tree_get_current(self->tree);