Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a2df0b4d authored by Huang Guobin's avatar Huang Guobin Committed by Greg Kroah-Hartman
Browse files

tty: Fix a possible resource leak in icom_probe 



[ Upstream commit ee157a79e7c82b01ae4c25de0ac75899801f322c ]

When pci_read_config_dword failed, call pci_release_regions() and
pci_disable_device() to recycle the resource previously allocated.

Reviewed-by: default avatarJiri Slaby <jirislaby@kernel.org>
Signed-off-by: default avatarHuang Guobin <huangguobin4@huawei.com>
Link: https://lore.kernel.org/r/20220331091005.3290753-1-huangguobin4@huawei.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent ba08cbc5

drivers/tty/serial/icom.c

+1 −1
Original line number Diff line number Diff line
@@ -1501,7 +1501,7 @@ static int icom_probe(struct pci_dev *dev, 
	retval = pci_read_config_dword(dev, PCI_COMMAND, &command_reg);

	if (retval) {

		dev_err(&dev->dev, "PCI Config read FAILED\n");

		return retval;

		goto probe_exit0;

	}



	pci_write_config_dword(dev, PCI_COMMAND,