Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a2a2f552 authored by Milton Miller's avatar Milton Miller Committed by Joel Becker
Browse files

ocfs2: char is not always signed 



Commit 1c66b360 (Change some lock status member in ocfs2_lock_res
to char.)  states that these fields need to be signed due to comparision
to -1, but only changed the type from unsigned char to char.   However, it
is a compiler option if char is a signed or unsigned type.  Change these
fields to signed char so the code will work with all compilers.

Signed-off-by: default avatarMilton Miller <miltonm@bga.com>
Signed-off-by: default avatarJoel Becker <joel.becker@oracle.com>
parent 1989a80a

fs/ocfs2/ocfs2.h

+3 −3
Original line number Diff line number Diff line
@@ -159,9 +159,9 @@ struct ocfs2_lock_res { 
	char                     l_name[OCFS2_LOCK_ID_MAX_LEN];

	unsigned int             l_ro_holders;

	unsigned int             l_ex_holders;

	char			 l_level;

	char			 l_requested;

	char			 l_blocking;

	signed char		 l_level;

	signed char		 l_requested;

	signed char		 l_blocking;



	/* Data packed - type enum ocfs2_lock_type */

	unsigned char            l_type;