Commit a26a4469 authored Nov 08, 2018 by Moni Shoua Committed by Greg Kroah-Hartman Dec 13, 2019

net/mlx5: Release resource on error flow



[ Upstream commit 698114968a22f6c0c9f42e983ba033cc36bb7217 ]

Fix reference counting leakage when the event handler aborts due to an
unsupported event for the resource type.

Fixes: a14c2d4b ("net/mlx5_core: Warn on unsupported events of QP/RQ/SQ")
Signed-off-by: Moni Shoua <monis@mellanox.com>
Reviewed-by: Majd Dibbiny <majd@mellanox.com>
Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 705d1e73

drivers/net/ethernet/mellanox/mlx5/core/qp.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -132,7 +132,7 @@ void mlx5_rsc_event(struct mlx5_core_dev *dev, u32 rsn, int event_type)
		if (!is_event_type_allowed((rsn >> MLX5_USER_INDEX_LEN), event_type)) {
		mlx5_core_warn(dev, "event 0x%.2x is not allowed on resource 0x%.8x\n",
		event_type, rsn);
		return;
		goto out;
		}

		switch (common->res) {
		@@ -150,7 +150,7 @@ void mlx5_rsc_event(struct mlx5_core_dev *dev, u32 rsn, int event_type)
		default:
		mlx5_core_warn(dev, "invalid resource type for 0x%x\n", rsn);
		}

		out:
		mlx5_core_put_rsc(common);
		}