Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a2617dc6 authored by majianpeng's avatar majianpeng Committed by Jaegeuk Kim
Browse files

f2fs: clean up the add_orphan_inode func 



For the code
> prev = list_entry(orphan->list.prev, typeof(*prev), list);
if orphan->list.prev == head, it can't get the right prev.
And we can use the parameter 'this' to add.

Signed-off-by: default avatarJianpeng Ma <majianpeng@gmail.com>
Signed-off-by: default avatarJaegeuk Kim <jaegeuk.kim@samsung.com>
parent aa43507f

fs/f2fs/checkpoint.c

+4 −12
Original line number Diff line number Diff line
@@ -219,19 +219,11 @@ void add_orphan_inode(struct f2fs_sb_info *sbi, nid_t ino) 
	new->ino = ino;



	/* add new_oentry into list which is sorted by inode number */

	if (orphan) {

		struct orphan_inode_entry *prev;



		/* get previous entry */

		prev = list_entry(orphan->list.prev, typeof(*prev), list);

		if (&prev->list != head)

			/* insert new orphan inode entry */

			list_add(&new->list, &prev->list);

	if (orphan)

		list_add(&new->list, this->prev);

	else

			list_add(&new->list, head);

	} else {

		list_add_tail(&new->list, head);

	}



	sbi->n_orphans++;

out:

	mutex_unlock(&sbi->orphan_inode_mutex);