Commit a2370ba2 authored Jan 05, 2017 by Andrzej Hajda Committed by Mauro Carvalho Chehab Jan 31, 2017

[media] v4l: s5c73m3: fix negation operator



Bool values should be negated using logical operators. Using bitwise operators
results in unexpected and possibly incorrect results.

Reported-by: David Binderman <dcb314@hotmail.com>
Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>

parent 21b5a1c3

drivers/media/i2c/s5c73m3/s5c73m3-ctrls.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -211,7 +211,7 @@ static int s5c73m3_3a_lock(struct s5c73m3 state, struct v4l2_ctrl ctrl)
		}

		if ((ctrl->val ^ ctrl->cur.val) & V4L2_LOCK_FOCUS)
		ret = s5c73m3_af_run(state, ~af_lock);
		ret = s5c73m3_af_run(state, !af_lock);

		return ret;
		}