Commit a200fadc authored Nov 08, 2013 by Ian Abbott Committed by Greg Kroah-Hartman Nov 11, 2013

staging: comedi: use refcount in comedi_driver_unregister()



Change `comedi_driver_unregister()` to call
`comedi_dev_get_from_minor()` instead of `comedi_dev_from_minor()` when
finding devices using the driver.  This increments the reference count
to prevent the device being removed while it is being checked to see if
it is attached to the driver.  Call `comedi_dev_put()` to decrement the
reference afterwards.

Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent fc406986

drivers/staging/comedi/drivers.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -662,7 +662,7 @@ void comedi_driver_unregister(struct comedi_driver *driver)

		/* check for devices using this driver */
		for (i = 0; i < COMEDI_NUM_BOARD_MINORS; i++) {
		struct comedi_device *dev = comedi_dev_from_minor(i);
		struct comedi_device *dev = comedi_dev_get_from_minor(i);

		if (!dev)
		continue;
		@@ -676,6 +676,7 @@ void comedi_driver_unregister(struct comedi_driver *driver)
		comedi_device_detach(dev);
		}
		mutex_unlock(&dev->mutex);
		comedi_dev_put(dev);
		}
		}
		EXPORT_SYMBOL_GPL(comedi_driver_unregister);