Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a1f5d1f0 authored by Antoine Tenart's avatar Antoine Tenart Committed by David S. Miller
Browse files

net: phy: sfp: warn the user when no tx_disable pin is available 



In case no Tx disable pin is available the SFP modules will always be
emitting. This could be an issue when using modules using laser as their
light source as we would have no way to disable it when the fiber is
removed. This patch adds a warning when registering an SFP cage which do
not have its tx_disable pin wired or available.

Signed-off-by: default avatarAntoine Tenart <antoine.tenart@bootlin.com>
Acked-by: default avatarRussell King <rmk+kernel@armlinux.org.uk>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 47de868b

drivers/net/phy/sfp.c

+9 −0
Original line number Diff line number Diff line
@@ -1065,6 +1065,15 @@ static int sfp_probe(struct platform_device *pdev) 
	if (poll)

		mod_delayed_work(system_wq, &sfp->poll, poll_jiffies);



	/* We could have an issue in cases no Tx disable pin is available or

	 * wired as modules using a laser as their light source will continue to

	 * be active when the fiber is removed. This could be a safety issue and

	 * we should at least warn the user about that.

	 */

	if (!sfp->gpio[GPIO_TX_DISABLE])

		dev_warn(sfp->dev,

			 "No tx_disable pin: SFP modules will always be emitting.\n");



	return 0;

}