Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a1e3e737 authored by Christophe Jaillet's avatar Christophe Jaillet Committed by David S. Miller
Browse files

mlxsw: spectrum_router: Return -ENOENT in case of error 



'vr' should be a valid pointer here, so returning 'PTR_ERR(vr)' is wrong.
Return an explicit error code (-ENOENT) instead.

Fixes: 61c503f9 ("mlxsw: spectrum_router: Implement fib4 add/del switchdev obj ops")
Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Acked-by: default avatarJiri Pirko <jiri@mellanox.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent e6dab902

drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c

+1 −1
Original line number Diff line number Diff line
@@ -1803,7 +1803,7 @@ int mlxsw_sp_router_fib4_del(struct mlxsw_sp_port *mlxsw_sp_port, 
					      sizeof(fib4->dst), fib4->dst_len);

	if (!fib_entry) {

		dev_warn(mlxsw_sp->bus_info->dev, "Failed to find FIB4 entry being removed.\n");

		return PTR_ERR(vr);

		return -ENOENT;

	}

	mlxsw_sp_fib_entry_del(mlxsw_sp_port->mlxsw_sp, fib_entry);

	mlxsw_sp_fib_entry_remove(vr->fib, fib_entry);