Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a19e4a1b authored by Baolin Wang's avatar Baolin Wang Committed by Greg Kroah-Hartman
Browse files

gpio: eic: sprd: Fix incorrect irq type setting for the sync EIC 



commit 102bbe34b31c9159e714432afd64458f6f3876d7 upstream.

When setting sync EIC as IRQ_TYPE_EDGE_BOTH type, we missed to set the
SPRD_EIC_SYNC_INTMODE register to 0, which means detecting edge signals.

Thus this patch fixes the issue.

Fixes: 25518e02 ("gpio: Add Spreadtrum EIC driver support")
Cc: <stable@vger.kernel.org>
Signed-off-by: default avatarBaolin Wang <baolin.wang@linaro.org>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent cffeb9c8

drivers/gpio/gpio-eic-sprd.c

+1 −0
Original line number Diff line number Diff line
@@ -414,6 +414,7 @@ static int sprd_eic_irq_set_type(struct irq_data *data, unsigned int flow_type) 
			irq_set_handler_locked(data, handle_edge_irq);

			break;

		case IRQ_TYPE_EDGE_BOTH:

			sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTMODE, 0);

			sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTBOTH, 1);

			irq_set_handler_locked(data, handle_edge_irq);

			break;