Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a19c921f authored by Takashi Iwai's avatar Takashi Iwai
Browse files

ALSA: lx646es: Fix possible uninitialized variable reference



lx_pipe_state() checks the return value from lx_message_send_atomic()
and breaks the loop only when it's a negative value.  However,
lx_message_send_atomic() may return a positive error code (as the
return code from the hardware), and then lx_pipe_state() tries to
compare the uninitialized current_state variable.

Fix this behavior by checking the positive non-zero error code as
well.

Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 3aa02cb6
Loading
Loading
Loading
Loading
+1 −1
Original line number Diff line number Diff line
@@ -644,7 +644,7 @@ static int lx_pipe_wait_for_state(struct lx6464es *chip, u32 pipe,
		if (err < 0)
			return err;

		if (current_state == state)
		if (!err && current_state == state)
			return 0;

		mdelay(1);