Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a120d9ab authored by Colin Ian King's avatar Colin Ian King Committed by David S. Miller
Browse files

netxen: fix incorrect loop counter decrement 



The loop counter k is currently being decremented from zero which
is incorrect. Fix this by incrementing k instead

Detected by CoverityScan, CID#401847 ("Infinite loop")

Fixes: 83f18a55 ("netxen_nic: fw dump support")
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent eac2c68d

drivers/net/ethernet/qlogic/netxen/netxen_nic_hw.c

+1 −1
Original line number Diff line number Diff line
@@ -2311,7 +2311,7 @@ netxen_md_rdqueue(struct netxen_adapter *adapter, 
				 loop_cnt++) {

		NX_WR_DUMP_REG(select_addr, adapter->ahw.pci_base0, queue_id);

		read_addr = queueEntry->read_addr;

		for (k = 0; k < read_cnt; k--) {

		for (k = 0; k < read_cnt; k++) {

			NX_RD_DUMP_REG(read_addr, adapter->ahw.pci_base0,

							&read_value);

			*data_buff++ = read_value;