Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a0a65a4a authored by Chao Yu's avatar Chao Yu Committed by Jaegeuk Kim
Browse files

f2fs: disallow switching io_bits option during remount 

If IO alignment feature is turned on after remount, we didn't
initialize mempool of it, it turns out we will encounter panic
during IO submission due to access NULL mempool pointer.

This feature should be set only at mount time, so simply deny
configuring during remount.

This fixes bug reported in bugzilla:

https://bugzilla.kernel.org/show_bug.cgi?id=204135



Signed-off-by: default avatarChao Yu <yuchao0@huawei.com>
Signed-off-by: default avatarJaegeuk Kim <jaegeuk@kernel.org>
parent d7ebeff9

fs/f2fs/super.c

+7 −0
Original line number Diff line number Diff line
@@ -1532,6 +1532,7 @@ static int f2fs_remount(struct super_block *sb, int *flags, char *data) 
	bool need_stop_gc = false;

	bool no_extent_cache = !test_opt(sbi, EXTENT_CACHE);

	bool disable_checkpoint = test_opt(sbi, DISABLE_CHECKPOINT);

	bool no_io_align = !F2FS_IO_ALIGNED(sbi);

	bool checkpoint_changed;

#ifdef CONFIG_QUOTA

	int i, j;
@@ -1611,6 +1612,12 @@ static int f2fs_remount(struct super_block *sb, int *flags, char *data) 
		goto restore_opts;

	}



	if (no_io_align == !!F2FS_IO_ALIGNED(sbi)) {

		err = -EINVAL;

		f2fs_warn(sbi, "switch io_bits option is not allowed");

		goto restore_opts;

	}



	if ((*flags & SB_RDONLY) && test_opt(sbi, DISABLE_CHECKPOINT)) {

		err = -EINVAL;

		f2fs_warn(sbi, "disabling checkpoint not compatible with read-only");