Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9f9f051d authored by Aaron Conole's avatar Aaron Conole Committed by Greg Kroah-Hartman
Browse files

openvswitch: switch from WARN to pr_warn 



[ Upstream commit fd954cc1919e35cb92f78671cab6e42d661945a3 ]

As noted by Paolo Abeni, pr_warn doesn't generate any splat and can still
preserve the warning to the user that feature downgrade occurred.  We
likely cannot introduce other kinds of checks / enforcement here because
syzbot can generate different genl versions to the datapath.

Reported-by: default avatar <syzbot+31cde0bef4bbf8ba2d86@syzkaller.appspotmail.com>
Fixes: 44da5ae5 ("openvswitch: Drop user features if old user space attempted to create datapath")
Cc: Thomas Graf <tgraf@suug.ch>
Signed-off-by: default avatarAaron Conole <aconole@redhat.com>
Acked-by: default avatarIlya Maximets <i.maximets@ovn.org>
Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 96e4b1fe

net/openvswitch/datapath.c

+2 −1
Original line number Diff line number Diff line
@@ -1551,7 +1551,8 @@ static void ovs_dp_reset_user_features(struct sk_buff *skb, struct genl_info *in 
	if (IS_ERR(dp))

		return;



	WARN(dp->user_features, "Dropping previously announced user features\n");

	pr_warn("%s: Dropping previously announced user features\n",

		ovs_dp_name(dp));

	dp->user_features = 0;

}