Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9f9980fa authored by Anand Jain's avatar Anand Jain Committed by Greg Kroah-Hartman
Browse files

btrfs: free btrfs_path before copying fspath to userspace 



commit 8cf96b409d9b3946ece58ced13f92d0f775b0442 upstream.

btrfs_ioctl_ino_to_path() frees the search path after the userspace copy
from the temp buffer @ipath->fspath. Which potentially can lead to a lock
splat warning.

Fix this by freeing the path before we copy it to userspace.

CC: stable@vger.kernel.org # 4.19+
Signed-off-by: default avatarAnand Jain <anand.jain@oracle.com>
Reviewed-by: default avatarDavid Sterba <dsterba@suse.com>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent cf178919

fs/btrfs/ioctl.c

+2 −0
Original line number Diff line number Diff line
@@ -4887,6 +4887,8 @@ static long btrfs_ioctl_ino_to_path(struct btrfs_root *root, void __user *arg) 
		ipath->fspath->val[i] = rel_ptr;

	}



	btrfs_free_path(path);

	path = NULL;

	ret = copy_to_user((void __user *)(unsigned long)ipa->fspath,

			   ipath->fspath, size);

	if (ret) {