Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9f7118b2 authored by Alexey Dobriyan's avatar Alexey Dobriyan Committed by Linus Torvalds
Browse files

proc: don't use READ_ONCE/WRITE_ONCE for /proc/*/fail-nth 

READ_ONCE and WRITE_ONCE are useless when there is only one read/write
is being made.

Link: http://lkml.kernel.org/r/20171120204033.GA9446@avx2


Signed-off-by: default avatarAlexey Dobriyan <adobriyan@gmail.com>
Cc: Akinobu Mita <akinobu.mita@gmail.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent e3912ac3

fs/proc/base.c

+2 −3
Original line number Diff line number Diff line
@@ -1370,7 +1370,7 @@ static ssize_t proc_fail_nth_write(struct file *file, const char __user *buf, 
	task = get_proc_task(file_inode(file));

	if (!task)

		return -ESRCH;

	WRITE_ONCE(task->fail_nth, n);

	task->fail_nth = n;

	put_task_struct(task);



	return count;
@@ -1386,8 +1386,7 @@ static ssize_t proc_fail_nth_read(struct file *file, char __user *buf, 
	task = get_proc_task(file_inode(file));

	if (!task)

		return -ESRCH;

	len = snprintf(numbuf, sizeof(numbuf), "%u\n",

			READ_ONCE(task->fail_nth));

	len = snprintf(numbuf, sizeof(numbuf), "%u\n", task->fail_nth);

	len = simple_read_from_buffer(buf, count, ppos, numbuf, len);

	put_task_struct(task);