Commit 9f5c6d87 authored Dec 09, 2017 by Masami Hiramatsu Committed by Arnaldo Carvalho de Melo Dec 27, 2017

perf probe: Add warning message if there is unexpected event name



This improve the error message so that user can know event-name error
before writing new events to kprobe-events interface.

E.g.
   ======
   #./perf probe -x /lib64/libc-2.25.so malloc_get_state*
   Internal error: "malloc_get_state@GLIBC_2" is an invalid event name.
     Error: Failed to add events.
   ======

Reported-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
Acked-by: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
Reviewed-by: Thomas Richter <tmricht@linux.vnet.ibm.com>
Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Paul Clarke <pc@us.ibm.com>
Cc: bhargavb <bhargavaramudu@gmail.com>
Cc: linux-rt-users@vger.kernel.org
Link: http://lkml.kernel.org/r/151275040665.24652.5188568529237584489.stgit@devbox


Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

parent 4e8fbc1c

tools/perf/util/probe-event.c

+8 −0

Original line number	Diff line number	Diff line
		@@ -2625,6 +2625,14 @@ static int get_new_event_name(char buf, size_t len, const char base,

		out:
		free(nbase);

		/* Final validation */
		if (ret >= 0 && !is_c_func_name(buf)) {
		pr_warning("Internal error: \"%s\" is an invalid event name.\n",
		buf);
		ret = -EINVAL;
		}

		return ret;
		}