Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9f0f048c authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman
Browse files

NFSD: prevent underflow in nfssvc_decode_writeargs() 



commit 184416d4b98509fb4c3d8fc3d6dc1437896cc159 upstream.

Smatch complains:

	fs/nfsd/nfsxdr.c:341 nfssvc_decode_writeargs()
	warn: no lower bound on 'args->len'

Change the type to unsigned to prevent this issue.

Cc: stable@vger.kernel.org
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarChuck Lever <chuck.lever@oracle.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 242a3e0c

fs/nfsd/nfsproc.c

+1 −1
Original line number Diff line number Diff line
@@ -228,7 +228,7 @@ nfsd_proc_write(struct svc_rqst *rqstp) 
	unsigned long cnt = argp->len;

	unsigned int nvecs;



	dprintk("nfsd: WRITE    %s %d bytes at %d\n",

	dprintk("nfsd: WRITE    %s %u bytes at %d\n",

		SVCFH_fmt(&argp->fh),

		argp->len, argp->offset);

fs/nfsd/xdr.h

+1 −1
Original line number Diff line number Diff line
@@ -33,7 +33,7 @@ struct nfsd_readargs { 
struct nfsd_writeargs {

	svc_fh			fh;

	__u32			offset;

	int			len;

	__u32			len;

	struct kvec		first;

};