Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9ed3cd33 authored by Patrice Chotard's avatar Patrice Chotard Committed by Linus Walleij
Browse files

pinctrl: abx500: allow to set pull up 



On ABx500 chip family, all pins support only pull down except for
AB8540 which supports pull up/down on some pins.
Rework abx500_pin_config_set to be able to set pull up on
pins which support this feature.

Signed-off-by: default avatarPatrice Chotard <patrice.chotard@st.com>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 10a8be54

drivers/pinctrl/pinctrl-abx500.c

+23 −1
Original line number Original line Diff line number Diff line
@@ -725,7 +725,7 @@ static int abx500_pin_config_set(struct pinctrl_dev *pctldev, 
	struct pullud *pullud = pct->soc->pullud;

	struct pullud *pullud = pct->soc->pullud;

	struct gpio_chip *chip = &pct->chip;

	struct gpio_chip *chip = &pct->chip;

	unsigned offset;

	unsigned offset;

	int ret;

	int ret = 0;

	enum pin_config_param param = pinconf_to_config_param(config);

	enum pin_config_param param = pinconf_to_config_param(config);

	enum pin_config_param argument = pinconf_to_config_argument(config);

	enum pin_config_param argument = pinconf_to_config_argument(config);
@@ -763,6 +763,28 @@ static int abx500_pin_config_set(struct pinctrl_dev *pctldev, 
				offset, argument ? 0 : 1);

				offset, argument ? 0 : 1);

		break;

		break;





	case PIN_CONFIG_BIAS_PULL_UP:

		/*

		 * if argument = 1 set the pull up

		 * else clear the pull up

		 */

		ret = abx500_gpio_direction_input(chip, offset);

		/*

		 * Some chips only support pull down, while some actually

		 * support both pull up and pull down. Such chips have

		 * a "pullud" range specified for the pins that support

		 * both features. If the pin is not within that range, do

		 * nothing

		 */

		if (pullud &&

		    pin >= pullud->first_pin &&

		    pin <= pullud->last_pin) {

			ret = abx500_config_pull_updown(pct,

				pin,

				argument ? ABX500_GPIO_PULL_UP : ABX500_GPIO_PULL_NONE);

		}

		break;



	case PIN_CONFIG_OUTPUT:

	case PIN_CONFIG_OUTPUT:

		ret = abx500_gpio_direction_output(chip, offset, argument);

		ret = abx500_gpio_direction_output(chip, offset, argument);