Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9e239362 authored by Alexander Usyskin's avatar Alexander Usyskin Committed by Greg Kroah-Hartman
Browse files

mei: drop iamthif_mtu from device structure 



We can receive mtu with one call now, no need to store it.

Signed-off-by: default avatarAlexander Usyskin <alexander.usyskin@intel.com>
Signed-off-by: default avatarTomas Winkler <tomas.winkler@intel.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent eeabfcf5

drivers/misc/mei/amthif.c

+1 −8
Original line number Diff line number Diff line
@@ -72,12 +72,6 @@ int mei_amthif_host_init(struct mei_device *dev, struct mei_me_client *me_cl) 


	mei_cl_init(cl, dev);



	/* Assign iamthif_mtu to the value received from ME  */



	dev->iamthif_mtu = me_cl->props.max_msg_length;

	dev_dbg(dev->dev, "IAMTHIF_MTU = %d\n", dev->iamthif_mtu);





	ret = mei_cl_link(cl, MEI_IAMTHIF_HOST_CLIENT_ID);

	if (ret < 0) {

		dev_err(dev->dev, "amthif: failed cl_link %d\n", ret);
@@ -239,7 +233,6 @@ static int mei_amthif_read_start(struct mei_cl *cl, struct file *file) 
{

	struct mei_device *dev = cl->dev;

	struct mei_cl_cb *cb;

	size_t length = dev->iamthif_mtu;

	int rets;



	cb = mei_io_cb_init(cl, MEI_FOP_READ, file);
@@ -248,7 +241,7 @@ static int mei_amthif_read_start(struct mei_cl *cl, struct file *file) 
		goto err;

	}



	rets = mei_io_cb_alloc_buf(cb, length);

	rets = mei_io_cb_alloc_buf(cb, mei_cl_mtu(cl));

	if (rets)

		goto err;

drivers/misc/mei/mei_dev.h

+0 −2
Original line number Diff line number Diff line
@@ -490,7 +490,6 @@ const char *mei_pg_state_str(enum mei_pg_state state); 
 * @iamthif_cl  : amthif host client

 * @iamthif_current_cb : amthif current operation callback

 * @iamthif_open_count : number of opened amthif connections

 * @iamthif_mtu : amthif client max message length

 * @iamthif_timer : time stamp of current amthif command completion

 * @iamthif_stall_timer : timer to detect amthif hang

 * @iamthif_state : amthif processor state
@@ -586,7 +585,6 @@ struct mei_device { 
	struct mei_cl iamthif_cl;

	struct mei_cl_cb *iamthif_current_cb;

	long iamthif_open_count;

	int iamthif_mtu;

	unsigned long iamthif_timer;

	u32 iamthif_stall_timer;

	enum iamthif_states iamthif_state;