Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9da7e9a7 authored by Dean Luick's avatar Dean Luick Committed by Doug Ledford
Browse files

IB/hfi1: Fix error condition that needs to clean up 



If input validation fails, properly free the request before returning.

Reviewed-by: default avatarIra Weiny <ira.weiny@intel.com>
Signed-off-by: default avatarDean Luick <dean.luick@intel.com>
Signed-off-by: default avatarDoug Ledford <dledford@redhat.com>
parent a383f8ec

drivers/infiniband/hw/hfi1/user_sdma.c

+2 −1
Original line number Diff line number Diff line
@@ -617,7 +617,8 @@ int hfi1_user_sdma_process_request(struct file *fp, struct iovec *iovec, 
	if (!info.npkts || req->data_iovs > MAX_VECTORS_PER_REQ) {

		SDMA_DBG(req, "Too many vectors (%u/%u)", req->data_iovs,

			 MAX_VECTORS_PER_REQ);

		return -EINVAL;

		ret = -EINVAL;

		goto free_req;

	}

	/* Copy the header from the user buffer */

	ret = copy_from_user(&req->hdr, iovec[idx].iov_base + sizeof(info),