Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9d90dafd authored by Alan Cox's avatar Alan Cox Committed by Linus Torvalds
Browse files

[PATCH] rio: fix array checking 



Found by an analysis tool and reported to the list. Fix is simple enough

Signed-off-by: default avatarAlan Cox <alan@redhat.com>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent 51018b0a

drivers/char/rio/rioctrl.c

+2 −2
Original line number Diff line number Diff line
@@ -662,7 +662,7 @@ int riocontrol(struct rio_info *p, dev_t dev, int cmd, unsigned long arg, int su 
			p->RIOError.Error = COPYIN_FAILED;

			return -EFAULT;

		}

		if (portStats.port >= RIO_PORTS) {

		if (portStats.port < 0 || portStats.port >= RIO_PORTS) {

			p->RIOError.Error = PORT_NUMBER_OUT_OF_RANGE;

			return -ENXIO;

		}
@@ -702,7 +702,7 @@ int riocontrol(struct rio_info *p, dev_t dev, int cmd, unsigned long arg, int su 
			p->RIOError.Error = COPYIN_FAILED;

			return -EFAULT;

		}

		if (portStats.port >= RIO_PORTS) {

		if (portStats.port < 0 || portStats.port >= RIO_PORTS) {

			p->RIOError.Error = PORT_NUMBER_OUT_OF_RANGE;

			return -ENXIO;

		}